-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Dust tree by age #413
Conversation
|
||
// 按照指定格式格式化为字符串 | ||
local_datetime.format("%Y%m%dT%H:%M:%S").to_string() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe: "%Y-%m-%dT%H:%M:%S"
Also lets get rid of the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will resubmit the code after testing the performance and fix this together
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick scan says it looks sensible. I am a bit worried about performance though
I created: #415 to track down the performance issues with a similar PR.
I will test my submitted performance test, if the test is OK, I will notify you to help me review the code. |
300565c
to
8770645
Compare
Hello, Tests with hyperfine show that this PR means we are running ~ 4% slower than the v1.0.0 release. I'm not sure if the performance test results are okay. Here are my test results. |
8770645
to
3ee3c16
Compare
I think this is sensible, I just want to sleep on it for a bit. |
My hyperfine tests show this branch is about 4% faster ! Either way its fine, I'm looking for drops of >10% before I get nervous. |
Why did you choose the flag |
hello, I chose randomly from the remaining single-letter parameters. I originally wanted to use -t but it was already taken. Do you have any other good suggestions? @bootandy |
I don't have other suggestions, I'll research some other tools to see if anyone has anything similar, but we'll go with -m if I can't find anything. |
Background
Dust tree by age #385
Add a new feature to dust to show the tree by age
Full Changelogs
Issue Reference
fix: Dust tree by age #385
Test Result
dust help command output

cargo test run test results
show by accesstime



show by modifiedtime
show by createdtime